Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign and/or remove support for Numerical coalescence style #157

Open
edejong-caltech opened this issue Apr 19, 2024 · 2 comments
Open

Comments

@edejong-caltech
Copy link
Member

Because quadgk is causing so many issues with optimization tests (and for future GPU support), we need to either rewrite our numerical coalescence style to use a different integration package; OR remove support altogether.

@trontrytel
Copy link
Member

Let me know what you ended up doing. We do use quadgk in CM.jl for one of the P3 scheme integrals...

@charleskawczynski - would it make sense to take the quadratures and quadloop out of the ClimaAtmos depths and make it into something that different repos can use for numerical integrals?

@charleskawczynski
Copy link
Member

Yeah, I think that would be useful. What are the errors we're seeing with quadgk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants