Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Enforce initialization of state.ρ as aux.ref_state.ρ in Anelastic1D model. #2111

Open
ilopezgp opened this issue Mar 13, 2021 · 3 comments
Assignees

Comments

@ilopezgp
Copy link
Contributor

Description

The validity of the Anelatic1D model right now relies on the user initializing state.ρ=aux.ref_state.ρ. We should have this initialization as default, and output a warning message if this initialization is overwritten.

@charleskawczynski
Copy link
Member

I'm not sure I understand the issue. state.ρ=aux.ref_state.ρ in the model seems like the right place for what we're doing. I think we can add a test at the end of the drivers to make sure that the final state.ρ is equal to the final aux.ref_state.ρ, otherwise, there are many places where the density could be modified (not just initialization).

@ilopezgp
Copy link
Contributor Author

Ok, a test for this seems fine. Could we add a callback that checks state.ρ≈aux.ref_state.ρ point wise?

@charleskawczynski
Copy link
Member

Yes, that seems fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants