Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a few non-trivial tests #13

Open
glwagner opened this issue Apr 25, 2023 · 5 comments
Open

Implement a few non-trivial tests #13

glwagner opened this issue Apr 25, 2023 · 5 comments
Assignees
Labels

Comments

@glwagner
Copy link
Member

Currently we've only got

which is of limited utility.

We have a bit of source code so we can add tests for that. #12 also adds some non-trivial docs.

@seamanticscience
Copy link
Collaborator

I added some type and reference coefficient tests for the carbon system in #11.

@seamanticscience
Copy link
Collaborator

...and now the testing of CarbonAlkalinityNutrients simulation runs successfully too (also in #11).

 Testing Running tests...
 Test Summary: | Pass  Total  Time
 CarbonSolvers |   24     24  7.6s
 Test Summary:                     | Pass  Total  Time
 NutrientsPlanktonBacteriaDetritus |    1      1  0.0s
 [ Info: Initializing simulation...
 [ Info:     ... simulation initialization complete (159.115 ms)
 [ Info: Executing initial time step...
 [ Info:     ... initial time step complete (32.222 seconds).
 [ Info: Simulation is stopping after running for 32.637 seconds.
 [ Info: Model iteration 3 equals or exceeds stop iteration 3.
 Test Summary:             | Pass  Total     Time
 CarbonAlkalinityNutrients |    3      3  1m18.3s
      Testing ClimaOceanBiogeochemistry tests passed 

@navidcy
Copy link
Collaborator

navidcy commented Feb 14, 2024

there exist some non-trivial tests atm; should we close this?

@navidcy navidcy added the tests label Feb 14, 2024
@seamanticscience
Copy link
Collaborator

@hengdiliang @emilyzakem would it be useful to add some checks associated with nutrients_plankton_bacteria_detritus.jl?

@glwagner
Copy link
Member Author

happy to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants