Default parameters values include Infs + missing parameters/catke_basic_conv_adj_parameters.jld2

[navidcy]

I'm trying to run the global simulations but seems to be missing parameters/catke_basic_conv_adj_parameters.jld2.

Also, some of the parameters have default Inf values. As far as I remember this creates issues? (CliMA/ParameterEstimocean.jl#295 (comment))

ClimaOcean.jl/examples/one_degree_near_global_simulation.jl

Lines 22 to 35 in 59cacf8

	neutral_default_mixing_length_parameters = (Cᵇu = Inf, Cᵇc = Inf, Cᵇe = Inf,
	Cˢu = Inf, Cˢc = Inf, Cˢe = Inf,
	CᴷRiᶜ = Inf, CᴷRiʷ = 0.0)
	neutral_default_tke_parameters = (CᵂwΔ = 0.0, Cᵂu★ = 0.0,
	Cᴰ⁻ = 0.0, Cᴰ⁺ = 0.0, CᴰRiᶜ = Inf, CᴰRiʷ = 0.0)
	mixing_length = MixingLength(; neutral_default_mixing_length_parameters...)
	turbulent_kinetic_energy_equation = TurbulentKineticEnergyEquation(; neutral_default_tke_parameters...)
	neutral_catke = CATKEVerticalDiffusivity(; mixing_length, turbulent_kinetic_energy_equation)
	catke_parameters_name = "catke_basic_conv_adj_parameters.jld2"
	catke_parameters_filename = joinpath("..", "parameters", catke_parameters_name)
	catke_parameters = load(catke_parameters_filename, "mean") # load ensemble mean parameters from EKI calibration

cc @glwagner, @simone-silvestri

[glwagner]

CATKE doesn't work yet, so try running without it.

[navidcy]

I did, and that worked fine!

[glwagner]

Also should mention that Inf is the "neutral" value for some parameters (ie if C=Inf then it does not affect the outcome). That's because they are combined with other parameters in a construction that's something like a = min(C1, C2, C3); therefore if C2=Inf it does not affect model outcome.