Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inference and use Base.precompile #775

Open
juliasloan25 opened this issue May 9, 2024 · 0 comments
Open

fix inference and use Base.precompile #775

juliasloan25 opened this issue May 9, 2024 · 0 comments
Labels
enhancement New feature or request 🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

Currently, we run the coupling loop for 2 timesteps before running for the full simulation length and timing it. As part of #706, we tried to use Base.precompile instead, but this didn't increase the accuracy of the timing. This is probably because of type inference failures of solve_coupler!. We should fix the inference, then replace the initial two timesteps with Base.precompile

@juliasloan25 juliasloan25 added enhancement New feature or request 🍃 leaf Issue coupled to a PR labels May 9, 2024
@juliasloan25 juliasloan25 changed the title use Base.precompile fix inference and use Base.precompile May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍃 leaf Issue coupled to a PR
Projects
None yet
Development

No branches or pull requests

1 participant