Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests on GPU - remove Fields.bycolumn #736

Open
Tracked by #571
LenkaNovak opened this issue Apr 15, 2024 · 1 comment · May be fixed by #805
Open
Tracked by #571

tests on GPU - remove Fields.bycolumn #736

LenkaNovak opened this issue Apr 15, 2024 · 1 comment · May be fixed by #805
Assignees
Labels
GPU 🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Apr 15, 2024

This is supposed to improve CPU performance when using threading. However, the gains are most likely marginal and this is not GPU compatible when other operators are being performed on the column (i.e. colidx is ignored on GPU). See #735 for an example of this problem and suggested solutions

Tests on GPU

bycolumn is also preventing GPU compatibility in flux_calculator_tests.jl and eisenman_seaice_tests.jl. Removing it should make those GPU compatible.

Solution

We can either remove the bycolumn loop completely, or replace this with Operators.column_mapreduce!. If it's not performant critical code, we could use Spaces.column

QA

  • make note of performance changes, both for CPU and GPU. Buildkite total job time suffices
@LenkaNovak
Copy link
Collaborator Author

also see CliMA/ClimaCore.jl#1609

@juliasloan25 juliasloan25 self-assigned this Apr 22, 2024
@juliasloan25 juliasloan25 added 🍃 leaf Issue coupled to a PR GPU and removed 💰 Grab Bag labels Apr 22, 2024
@juliasloan25 juliasloan25 changed the title Remove Fields.bycolumn tests on GPU - remove Fields.bycolumn Apr 24, 2024
@juliasloan25 juliasloan25 linked a pull request May 20, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU 🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants