You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is supposed to improve CPU performance when using threading. However, the gains are most likely marginal and this is not GPU compatible when other operators are being performed on the column (i.e. colidx is ignored on GPU). See #735 for an example of this problem and suggested solutions
Tests on GPU
bycolumn is also preventing GPU compatibility in flux_calculator_tests.jl and eisenman_seaice_tests.jl. Removing it should make those GPU compatible.
Solution
We can either remove the bycolumn loop completely, or replace this with Operators.column_mapreduce!. If it's not performant critical code, we could use Spaces.column
QA
make note of performance changes, both for CPU and GPU. Buildkite total job time suffices
The text was updated successfully, but these errors were encountered:
This is supposed to improve CPU performance when using threading. However, the gains are most likely marginal and this is not GPU compatible when other operators are being performed on the column (i.e.
colidx
is ignored on GPU). See #735 for an example of this problem and suggested solutionsTests on GPU
bycolumn
is also preventing GPU compatibility influx_calculator_tests.jl
andeisenman_seaice_tests.jl
. Removing it should make those GPU compatible.Solution
We can either remove the
bycolumn
loop completely, or replace this withOperators.column_mapreduce!
. If it's not performant critical code, we could useSpaces.column
QA
The text was updated successfully, but these errors were encountered: