Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code is not tested or run #66

Open
LilithHafner opened this issue Jan 27, 2024 · 3 comments
Open

Example code is not tested or run #66

LilithHafner opened this issue Jan 27, 2024 · 3 comments
Labels
Acknowledged We are aware of this issue and will respond soon

Comments

@LilithHafner
Copy link
Contributor

This leads to issues like
#65
#62
#56

@Clemapfel Clemapfel added the Acknowledged We are aware of this issue and will respond soon label Feb 8, 2024
@Clemapfel
Copy link
Owner

I agree, the main issue is that Documenter.jl doctest macro does not work with Mousetrap, as it needs to create a new window and application instance anytime any of the code snippets is run, since they are all completely sandboxed.

You are still right though, I should find another automated system to run all the example snippets

@Clemapfel
Copy link
Owner

Fixed by multiple commits such as b72910a, all runnable code in the docs is now run once when the docs are built, avoiding future typos.

This fix will go live with 3.4

@LilithHafner
Copy link
Contributor Author

Thank you! Well done! Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged We are aware of this issue and will respond soon
Projects
None yet
Development

No branches or pull requests

2 participants