Client freeze due to infinite loop in render thread #1674
Comments
|
I believe this is caused by the packet decompression and circularbuffer when plugins are active. here are some samples from my packetdumps: This is a packet that begins part way through data that belongs inside and ID: 78. it's incorrectly processing the 0A as the ID because bytes have gone missing from the capture from the buffer. (assuming some offsetting issue but im not sure) It proceeds to read the next few packets incorrectly as well since they are offset due to the missing bytes. the client recovers everything except movement input and occasionally opens random gumps due to bad data and incorrectly IDd packets. This packet begins in the middle of an ID: 77 and clobbers quite a few packets. This packet starts in the middle of an ID: 77 and clobbers many packets I have more samples if needed but I've already made this post a wall. Aside from the weirdly offset packets with missing bytes above sometimes the CUO packet dump just logs a large string of NUL. I thought the lock would help but I think its a combination of the buffer array and the decompression causing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The client permanently freezes, and the window becomes unresponsive.
To Reproduce
It's very rare and hard to reproduce, I've only tested it with Razor Enhanced, but it seems to be happening with scripts that make the player move, be it a single step with the Walk function or the RE pathfinding.
Expected behavior
Not freezing.
Information (please complete the following information):
Additional context
When I attach a debugger what I see is that the logic is stuck in this loop:
ClassicUO/src/ClassicUO.Client/Game/Scenes/GameSceneDrawingSorting.cs
Lines 135 to 137 in b5eaa38
The loop takes the next object to process via
obj.TNext, what I notice is that theobjrefers to my player and thatTNextis always my player, which causes the infinite loop.I tried to add code in all the places where
TNextis set, to catch when such connection between the objects is done, but I haven't been able to properly catch it yet.The text was updated successfully, but these errors were encountered: