Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement request: Add a delimiter for item name in journal for shops #1628

Open
Muramas opened this issue Jul 21, 2023 · 0 comments
Open

Comments

@Muramas
Copy link

Muramas commented Jul 21, 2023

Right now if you are trying to sell something in your journal it says something like
[] [Razor]: …item ID:1325207997 Price: 99999 Description: this is an example

The issue with this is that between the description and the item name there is no delimiter so we know the difference between the item's name and the description. One of the scripts for detecting shops can only be used when there is no description.

  1. This will allow scanning for shops with descriptions
  2. This will improve journal readability
  3. This will allow merchant data scrapers to do things like find bags with key phrases such as "leather set" to market sets instead of only individual items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant