Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore re-adding '-no-reboot' in combination with printing a "success" string before shutting down #96

Open
nathanchance opened this issue Mar 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nathanchance
Copy link
Member

We added -no-reboot unconditionally to QEMU in #65, which we had to revert in #95 to avoid missing potential problems (#94).

-no-reboot is helpful for avoiding timeout overhead but we need to be able to determine when a machine has panicked and gone to reboot versus exiting cleanly. pvpanic aims to make that possible from my understanding but we cannot guarantee that CONFIG_PVPANIC is enabled in the kernels that we are booting.

@ojeda suggested that we could echo some string like we print /proc/version before shutting down the machine then check for that string to know whether or not a boot is successful. There are two immediate downsides I see to this approach versus our current relying on timeout strategy:

  1. Having to rebuild the rootfs images, which increases the repo size (perhaps we should explore setting up a separate repo for those images and making it a submodule of this one?)
  2. Other projects using boot-utils (such as my personal testing framework) will have to code the same logic as our CI for parsing the output of QEMU (not difficult, so who cares).
@nathanchance nathanchance added the enhancement New feature or request label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant