New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suite compliant with PostGIS #43
Comments
Upon further research, going to need to revise some of these recommendations. Would be better to use (as described in https://carto.com/blog/nearest-neighbor-joins) |
Bugs identified by this issue:
|
This is just notes of the issues I saw for now, I will clean this up later / split into separate issues:
http://postgis.net/docs/ST_NPoints.html (wrong function)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L122
http://postgis.net/docs/ST_Distance.html (cast to geography)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L130
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L143 (could be replaced by the star variable above?)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L154 (should this be "location" and not the_geom??)
http://postgis.net/docs/ST_Intersects.html (the WKT needs to be casted to geometry)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L274
http://postgis.net/docs/ST_MakeEnvelope.html (need to swap order here, socrata within_box is different ordering of xmin, ymax, xmax, ymin than what postgis expects)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L290
http://postgis.net/docs/ST_Within.html (the WKT needs casting to geometry maybe? or use st_geomfromtext?)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L306
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L314 (missing - but you could easily do carto's updated_at maybe?)
https://github.com/CityOfPhiladelphia/soda-carto/blob/master/test/index.js#L394 (missing?)
The text was updated successfully, but these errors were encountered: