Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server fails when favicon.ico is requested by a browser #24

Open
andrewbt opened this issue Feb 9, 2017 · 1 comment
Open

Server fails when favicon.ico is requested by a browser #24

andrewbt opened this issue Feb 9, 2017 · 1 comment

Comments

@andrewbt
Copy link
Contributor

andrewbt commented Feb 9, 2017

We should probably make things more fault-tolerant

@andrewbt andrewbt added the bug label Feb 9, 2017
@timwis
Copy link
Contributor

timwis commented Feb 9, 2017

Yeah, I don't know why the browser is requesting favicon.ico on a json page -- normally it doesn't do that if the response Content-Type header is set to application/json. In fact, I thought I added that header to server.js and that fixed it. But it's definitely happening in the lambda function :/ at least it doesn't fail, it just shows an error in the network tab.

Are you just using server.js because it's easier to test? If so, we can definitely make it handle unknown routes pretty easily. I was also thinking of having server.js just delegate processing to handler.js (since handler.js is just a pure function) to have more parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants