Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for handler.js #22

Open
timwis opened this issue Feb 9, 2017 · 1 comment
Open

Add tests for handler.js #22

timwis opened this issue Feb 9, 2017 · 1 comment
Projects
Reverse Proxy Implementation

Comments

@timwis
Copy link
Contributor

timwis commented Feb 9, 2017

There's some logic and decision-making in handler.js that we'd have a few tests for, ideally. It's more challenging because we have to mock request using something like proxyquire though.

This definitely isn't MVP though.
@timwis
Copy link
Contributor Author

timwis commented Feb 10, 2017 •
edited

Also there's no test around the CSV format, at least the ST_AsText bit, the logic for which is in index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Reverse Proxy Implementation
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timwis