Some kesäseteli tests fail randomly on employer and youth

[sirtawast]

Youth

How to reproduce:

frontend/kesaseteli/youth
yarn test -t "when submitting form" additional_info.test.tsx;
# Or on unix, loop till failure
while yarn test -t "when submitting form" additional_info.test.tsx; do :; done

FAIL src/__tests__/additional_info.test.tsx (66.388 s)
  frontend/kesaseteli/youth/src/pages/additional_info.tsx
    ✓ should not violate accessibility (712 ms)
    ✓ shows error toast when backend returns bad request (849 ms)
    ✓ redirects to 500 -error page when backend returns unexpected error (495 ms)
    ✓ shows that application is not found when id query param is not present (723 ms)
    ✓ shows that application is not found when backend returns 404 (1088 ms)
    when application status is "additional_information_requested"
      ✓ shows additional info form (1126 ms)
    when application status is "additional_information_provided"
      ✓ shows that additional info is sent (1144 ms)
    when application status is "accepted"
      ✓ shows that additional info is sent (1092 ms)
    when application status is "rejected"
      ✓ shows that additional info is sent (1140 ms)
    when application status is "submitted"
      ✓ shows that application is not found (1105 ms)
    when application status is "awaiting_manual_processing"
      ✓ shows that application is not found (1199 ms)
    when submitting form
      ✓ shows errors if empty values (2387 ms)
      sends filled form data to the backend
        ✓ with default language (32730 ms)
        ✕ with changed language (13448 ms)

Employer

How to reproduce:

cd frontend/kesaseteli/employer
yarn test
# Or on unix, loop till failure
while yarn test; do :; done

 FAIL  src/__tests__/application.test.tsx (247.85 s)
  frontend/kesaseteli/employer/src/pages/application.tsx
    ✓ should not violate accessibility (771 ms)
    loading data
      ✓ Should redirect to login when unauthorized (618 ms)
      when authorized
        ✓ Should route to index page with default lang when applicaton id and locale is missing (882 ms)
        ✓ Should route to index page with locale when applicaton id is missing (874 ms)
        When loading application from backend returns error page
          ✓ Should redirect to errorPage (911 ms)
        when loading application returns data
          ✕ shows validation errors and disables continue button when missing values (60795 ms)
          ✓ shows validation errors when value is too long (59981 ms)
          ✕ saves application when next button is clicked (61656 ms)
          ✓ can traverse between wizard steps (40500 ms)

[karisal-anders]

With the PR #2876 ("test: use swc-jest to improve performance") merged, please could you @sirtawast report if the mentioned tests fail in CI/CD pipeline still? Thank you!

[karisal-anders]

@sirtawast PR #2981 should now fix this. If this still happens, please would you give feedback to the Comodori team, e.g. on #comodori on city of Helsinki's Slack—in that case you can merge your PR with these tests failing in the CI/CD to not impede your PR just because of this—but please if these still fail at least I'd really like to know, thank you!

[karisal-anders]

Helsinki benefit team members @sirtawast @EmiliaMakelaVincit @rikuke have you encountered any of these problems mentioned in this issue in CI/CD pipelines anymore after May 9th? If you haven't I'd be willing to close this by the end of this month unless some problems still show up during this month.