Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Body Rotation doesn't persist properly #2770

Open
Garfieldwxg55 opened this issue Mar 18, 2022 · 4 comments
Open

NPC Body Rotation doesn't persist properly #2770

Garfieldwxg55 opened this issue Mar 18, 2022 · 4 comments
Labels
Confirmed Bug A bug was reported and confirmed by experienced users. Research To Do The development team needs to research the issue.

Comments

@Garfieldwxg55
Copy link

/version output

This server is running Paper version git-Paper-260 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT) (Git: bc68ee0)
You are running the latest version
Previous version: git-Paper-252 (MC: 1.18.2)

/version Citizens output

Citizens version 2.0.29-SNAPSHOT (build 2509)

Log file

https://paste.denizenscript.com/View/94426

config.yml

https://paste.denizenscript.com/View/94425

saves.yml

https://paste.denizenscript.com/View/94424

Profiler report

No response

Description

I've noticed that NPC's saving their rotation when a player leaves and rejoins a server is really inconsistant. Some NPCs from older versions of the plugin seem to have saved their rotation correctly, but my newer ones don't seem to do that and instead face their heads in the right direction but their bodies will be awkwardly rotated. I've tried setting their rotation with /lookclose, but they go back to their old rotation after I leave the server and rejoin.

@mcmonkey4eva mcmonkey4eva added the Confirmed Bug A bug was reported and confirmed by experienced users. label Mar 18, 2022
@mcmonkey4eva mcmonkey4eva changed the title NPCs rotate and can't properly save a rotation NPC Body Rotation doesn't persist properly Mar 18, 2022
@mcmonkey4eva
Copy link
Member

Update from testing and discussion in the dev channels:

Body rotation on older versions was synchronized to the head rotation by displaying an arm-swing animation, as this would force the body to match the head clientside. The NPC's head was then rotated from there to match the saved rotation.

In 1.18.2, this appears to no longer work:

Meaning, a new solution to the issue will have to be found to correctly sync body&head yaw in modern minecraft versions.

@mcmonkey4eva mcmonkey4eva added the Research To Do The development team needs to research the issue. label Mar 19, 2022
@fullwall
Copy link
Member

fullwall commented Apr 5, 2022

Just updating here from a few weeks ago; Minecraft arm swing code hasn't changed, unfortunately nothing else has been added to sync / set body yaw for players.

@mcmonkey4eva
Copy link
Member

It has been requested by another user* to have a command to link head/body rotation to the same value automatically.

Relatedly it'd also be nice to have something like a /npc moveto --body [yaw]

(* who unfortunately had to be blocked from this repo and Discord due to the inappropriate argumentative way they about it)

@CitizensDev CitizensDev deleted a comment from NotifiedGaming Sep 16, 2022
@JellyTale
Copy link

This issue has changed(?). Body rotation now persists, but head rotation for player NPCs always defaults to south for some reason. If you leave an NPC's active area and then load it back in, its head will face south by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Bug A bug was reported and confirmed by experienced users. Research To Do The development team needs to research the issue.
Projects
None yet
Development

No branches or pull requests

4 participants