Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item frames send map data to NPCs, causing major TPS loss #2697

Open
AnttiMK opened this issue Dec 6, 2021 · 1 comment
Open

Item frames send map data to NPCs, causing major TPS loss #2697

AnttiMK opened this issue Dec 6, 2021 · 1 comment
Assignees
Labels
Research To Do The development team needs to research the issue.

Comments

@AnttiMK
Copy link

AnttiMK commented Dec 6, 2021

/version output

This server is running Paper version git-Paper-391 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 3e73355 on ver/1.17.1)
You are running the latest version

/version Citizens output

Citizens version 2.0.29-SNAPSHOT (build 2419)
Website: http://www.citizensnpcs.co
Author: fullwall

Log file

https://paste.denizenscript.com/View/90653

config.yml

https://paste.denizenscript.com/View/90650

saves.yml

https://paste.denizenscript.com/View/90652

Profiler report

Spark: https://spark.lucko.me/COnWBnhsvn
Timings: https://timings.pl3x.net/?id=4570e43d44194f709db504080dbe97ae (ignore the Pl3x link, server is Paper)
After removing Citizens: https://spark.lucko.me/JTofJ4CC4G

Description

Our hub has ~200 maps in item frames, used to display large images to players. I noticed a lot of TPS loss, and after some debugging & Citizens Discord support messages, it seems that item frames with maps are constantly sending map updates to NPCs (about 40 of them), causing major TPS loss on the server. By removing Citizens from the server, the lag disappears completely.

@fullwall
Copy link
Member

fullwall commented Jan 1, 2022

Fixed in 1.18 but trickier to work around in previous versions. Needs a bit more thought.

@mcmonkey4eva mcmonkey4eva added the Research To Do The development team needs to research the issue. label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Research To Do The development team needs to research the issue.
Projects
None yet
Development

No branches or pull requests

3 participants