Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary warning message in libfreshclam_internal.c #930

Closed
09001413 opened this issue May 28, 2023 · 2 comments · Fixed by #935
Closed

Unnecessary warning message in libfreshclam_internal.c #930

09001413 opened this issue May 28, 2023 · 2 comments · Fixed by #935

Comments

@09001413
Copy link

Sorry Micah @micahsnyder , I don't know if this should be reported as a bug, but it does bother us.

I found the following line of code inside libfreshclam_internal.c. Although the download executes properly, a warning message still appears. This message is picked up by our log monitoring system and alerted.

logg(LOGG_WARNING, " ******* RESULT %ld, SIZE: %zu ******* \n", http_code, receivedFile.size).

If this is an info message, can you lower its level to info level, or can you judge it based on the http code and not let it give a warning message if the code is 200? (Sorry, I am not a C player, so I raised this issue instead of raising a PR)

Thank you in advance.

@micahsnyder
Copy link
Contributor

micahsnyder commented May 28, 2023

@09001413 It bothers me too. I'm sorry about any confusion it may have caused. We'll have it fixed in 1.1.1.

Edit: My plan is to remove that line entirely. It was added to test something and accidentally committed and ne one noticed my mistake during review.

@09001413
Copy link
Author

@micahsnyder Thank you very much! we will wait for version 1.1.1.

micahsnyder added a commit to micahsnyder/clamav-micah that referenced this issue May 30, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: Cisco-Talos#930
micahsnyder added a commit to micahsnyder/clamav-micah that referenced this issue Jun 1, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: Cisco-Talos#930
micahsnyder added a commit that referenced this issue Jun 1, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: #930
micahsnyder added a commit that referenced this issue Jun 1, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: #930
@micahsnyder micahsnyder pinned this issue Jun 1, 2023
micahsnyder added a commit to micahsnyder/clamav-micah that referenced this issue Oct 3, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: Cisco-Talos#930
micahsnyder added a commit that referenced this issue Oct 20, 2023
A warning printing the HTTP code and file size was accidentally
committed at the end of ClamAV 1.1.0 dev when fixing a bug.
Remove this warning.

Resolves: #930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants