Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent names #14

Open
sorokya opened this issue Dec 31, 2023 · 0 comments
Open

Inconsistent names #14

sorokya opened this issue Dec 31, 2023 · 0 comments

Comments

@sorokya
Copy link
Contributor

sorokya commented Dec 31, 2023

Mostly a brain dump of things I found weird

  • welcome_code not welcome_reply (all other reply packets use the x_reply naming

  • spell vs skill (should stick with skill I think)

  • item vs buy_item sell_item drop_item etc (think we should keep it simple and just use item)

  • base and secondary vs base_stats and secondary_status

  • NpcType::Trainer should be SkillMaster ?

  • victim vs target (victim doesn't really make sense for heal spells

  • level_up should be level_up_stats in npc packets

  • ChestReply server packet could use Item rather than item_id and remaining_item_amount

Will add more later probably. Ignore until I let you know it's complete :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant