Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different sources and "targets" #84

Open
jessjaco opened this issue Nov 9, 2020 · 2 comments
Open

Different sources and "targets" #84

jessjaco opened this issue Nov 9, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jessjaco
Copy link
Contributor

jessjaco commented Nov 9, 2020

How possible would it be to implement the ability to have different source and "target" layers?

@jessjaco jessjaco changed the title Difference sources and "targets" Different sources and "targets" Nov 9, 2020
@vlandau
Copy link
Member

vlandau commented Nov 9, 2020

You'd have to hack the code a bit, but it would be possible. First, you would need to add a new argument (raster input) for the targets, and feed that into the get_targets and get_ground function. One problem is that the total current injected for each moving window solve is equal to the source strength of the target pixel (see here), so you'd also have to hack get_source as well, so that it instead just uses the raw values of the source strength layer. I think you would also have to set any source pixels that fall within the target block to 0. There's probably a few things I'm missing, but I think those are the major things.

@vlandau
Copy link
Member

vlandau commented Nov 9, 2020

Actually on second look, you wouldn't have to adjust get_source at all, as long as you're okay with the total current being equal to the strength of target pixels (see the strength argument to get_source).

@vlandau vlandau added the enhancement New feature or request label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants