Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project_name is not respected when doing successive runs #146

Open
tpoisot opened this issue Dec 1, 2023 · 2 comments
Open

project_name is not respected when doing successive runs #146

tpoisot opened this issue Dec 1, 2023 · 2 comments

Comments

@tpoisot
Copy link

tpoisot commented Dec 1, 2023

If the project name key is set to x, successive calls to run_omniscape will write files in x, x_1, x_2, ...

I get the idea of not losing outputs, but it's a little annoying as it's not documented anywhere and there doesn't seem to be an easy way to get the path of where the files are.

@vlandau
Copy link
Member

vlandau commented Jan 8, 2024

Good point about not being able to get output location for a specific run. What do you propose? I could prompt for user input to confirm overwriting the files, or alternatively, I could log the location of the outputs more clearly and print them at the end of the run? There are already so damn many settings that I don't want to add another about overwriting existing outputs, but I suppose I could, just default it to false, and in those cases, print log warnings about existing outputs and the location of new outputs.

@vlandau
Copy link
Member

vlandau commented Jan 31, 2024

@tpoisot I added a warning at the very beginning of a run that will let the user know if the directory already exists and print the location where outputs will be written. There is probably a more elegant solution, so I can leave this open if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants