Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Bool values in cfg of in-memory run_omniscape? #126

Open
jessjaco opened this issue Nov 14, 2022 · 2 comments
Open

Allow Bool values in cfg of in-memory run_omniscape? #126

jessjaco opened this issue Nov 14, 2022 · 2 comments

Comments

@jessjaco
Copy link
Contributor

The in memory version of run_omniscape has type Dict{String, String} for the cfg arg. Might it make sense to allow Bool values too, for e.g. calc_normalized_current?

@vlandau
Copy link
Member

vlandau commented Nov 28, 2022

It would be easy to update the dict type requirement Dict{String, Any} or Dict{String, Union{String, Bool}, but we'd have to make sure we're parsing things correctly. My original thought was that it's a bit easier to just enforce String as the value type for all keys so we always know what type to expect when parsing things.

@jessjaco
Copy link
Contributor Author

Oh right, now I realize the numeric types are string too. Yeah, probably a low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants