Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile Review #2

Open
satu0king opened this issue Nov 4, 2020 · 3 comments
Open

Dockerfile Review #2

satu0king opened this issue Nov 4, 2020 · 3 comments

Comments

@satu0king
Copy link
Member

I created a basic Dockerfile. However, I am not sure if it is production ready and/or can handle multiple requests. Please review.

@tachyons @Nitish145 @shubhankarsharma00 @gr455 any inputs here?

@gr455
Copy link
Member

gr455 commented Nov 4, 2020

@satu0king what do you mean by handling multiple requests?

@satu0king
Copy link
Member Author

@satu0king what do you mean by handling multiple requests?

I think it should be able to handle requests in parallel as the code is asynchronous afik. But I was wondering if we need to do any configuration in express/node for production settings like we have in rails.

Also something like using Babel for production build as described in this article: https://www.sentinelstand.com/article/docker-with-node-in-development-and-production

@tachyons
Copy link
Member

tachyons commented Nov 4, 2020

Use latest nodejs version, rest looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants