Added "close" icon when navbar-toggler is clicked #252
+37
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @tanmoysrt @Prerna-0202 please review. |
cc @Arnabdaz |
|
keeping your pr on hold as there is already a pr for navbar upgrade #177 & as it is related to mobile version of simulator it needs to implemented after proper planning |
|
Hi @antriksh-9 this issue is already completed by the pr CircuitVerse/CircuitVerse#4502 |
|
Hey @DhairyaMajmudar this PR solves the issue for vue-simulator and not for the main website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Describe the changes you have made in this PR -
Added a "close" icon, replacing the the default icon navbar-toggler when it is clicked.
Screenshots of the changes (If any) -
solution.mp4