Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction in Interactive-gates page #473

Open
harshitaaaaaa opened this issue Oct 6, 2020 · 11 comments · May be fixed by #600
Open

Correction in Interactive-gates page #473

harshitaaaaaa opened this issue Oct 6, 2020 · 11 comments · May be fixed by #600
Labels
dark mode context related to dark mode in particular only

Comments

@harshitaaaaaa
Copy link

The wires of circuit are not visible in the dark mode.

Screenshot from 2020-10-07 00-52-20

Here, Under the section: Two way light switch and security light, wires are clearly visible.

Screenshot from 2020-10-07 00-52-27

But as we switch to dark mode, the wires are not visible properly because the color of wires is overlapping with the color of the background.
@anushri20
Copy link
Contributor

Can I work on this?

@YashKumarVerma
Copy link
Member

yes

@anushri20
Copy link
Contributor

Thanks!

@Shivansh2407
Copy link
Member

Shivansh2407 commented Oct 8, 2020 •
edited

Hey @anushri20 , glad to see your enthusiasm to contribute to the Book, Currently the Codebase is undergoing a lot of transformations, it is better if you can fix the issues recently opened for the GSOD 2020 branch #475 , #476 . We will merge the PRs currently only for the GSOD 2020 branch . Looking forward to your PRs.

@anushri20
Copy link
Contributor

Okay, Thank you for letting me know @Shivansh2407

@pavanjoshi914
Copy link
Member

pavanjoshi914 commented Mar 14, 2021 •
edited

@Shivansh2407 in new structure of book( gsod branch) it is in http://localhost:4000/docs/comb-ssi/logic-gates.html i was thinking of rising a new issue for it.
2021-03-14_07-13
wire after gate needs to be white i would like to fix it. also the embed area for logic gate is dark which is hard to find in dark mode
shall we try to change color of it too?

png for input is this
2021-03-14_07-26
png for output is this
2021-03-14_07-24
we need png for output in sync with png for input any suggestion where i can create new png
also gate images for xor and xnor must be in sync (both in square) , green border is looking good for drop
2021-03-14_07-33

also in dark mode i am unable to see truth tables loaded
2021-03-14_07-34
shall I raise new issue @Shivansh2407 and start working on it

@manjotsidhu
Copy link
Member

@pavanjoshi914 you can work on it and since GSoD2020 is merged, you can directly work on master branch.

@manjotsidhu manjotsidhu added the dark mode context related to dark mode in particular only label May 30, 2021
@Palaksharma23
Copy link
Member

can I take up this issue ?

@pavanjoshi914
Copy link
Member

you can take this @Palaksharma23

@Palaksharma23
Copy link
Member

@pavanjoshi914 thank you sir

@Palaksharma23 Palaksharma23 linked a pull request Dec 19, 2021 that will close this issue
Open
1 task
@sharko7
Copy link

sharko7 commented Jan 29, 2022

Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dark mode context related to dark mode in particular only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solved the issue for wire visibilty in dark mode Fixes #473 Palaksharma23/Interactive-Book
8 participants
@YashKumarVerma @manjotsidhu @Shivansh2407 @anushri20 @pavanjoshi914 @harshitaaaaaa @sharko7 @Palaksharma23