Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added code for back-to-top button #315

Closed
wants to merge 4 commits into from
Closed

feat: added code for back-to-top button #315

wants to merge 4 commits into from

Conversation

vedant-jain03
Copy link
Member

@vedant-jain03 vedant-jain03 commented Oct 23, 2021 •
edited

  • Formatted the code for better understanding and cleanliness of the code.
  • added code for back-to-top button

Fixes #314

Ref #

Changes done:

  • Task 1

Screenshots:

bandicam.2021-10-23.21-49-31-780.mp4

Preview Link(s):

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

@vedant-jain03
Copy link
Member Author

vedant-jain03 commented Oct 23, 2021 •
edited

@Shivansh2407 @manjotsidhu @tachyons

manjotsidhu
manjotsidhu suggested changes Oct 24, 2021
View reviewed changes
Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in the video preview, back to top button is not hidden when the scroll is reached to the top ?

@vedant-jain03 vedant-jain03 reopened this Oct 24, 2021
@vedant-jain03
Copy link
Member Author

Why in the video preview, back to top button is not hidden when the scroll is reached to the top ?

@manjotsidhu Let me add that functionality too sir, I tried using windows.onload but it was not giving the proper response. Should I use different method for that?

@manjotsidhu
Copy link
Member

Why in the video preview, back to top button is not hidden when the scroll is reached to the top ?

@manjotsidhu Let me add that functionality too sir, I tried using windows.onload but it was not giving the proper response. Should I use different method for that?

No need of window.onload, just put that script before body end tag.

nitin10s
nitin10s requested changes Oct 24, 2021
View reviewed changes
docs/styles/theme.css Outdated Show resolved Hide resolved
@vedant-jain03
Copy link
Member Author

vedant-jain03 commented Oct 25, 2021 •
edited

@manjotsidhu @nitin10s

bandicam.2021-10-25.16-48-39-105.mp4
  • Added the hidden when the scroll is reached to the top.
  • Changes primary-color
    Kindly Review

manjotsidhu
manjotsidhu approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vedant-jain03
Copy link
Member Author

vedant-jain03 commented Nov 6, 2021 •
edited

@nitin10s @tachyons Kindly Review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manjotsidhu manjotsidhu manjotsidhu approved these changes

@nitin10s nitin10s Awaiting requested review from nitin10s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Scroll-to-top Button
3 participants
@vedant-jain03 @manjotsidhu @nitin10s