Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong label on dark mode toggler #298

Open
ShreyaPrasad1209 opened this issue Jun 21, 2021 · 11 comments · May be fixed by #309
Open

Wrong label on dark mode toggler #298

ShreyaPrasad1209 opened this issue Jun 21, 2021 · 11 comments · May be fixed by #309
Labels
good first issue Good for newcomers
Projects
Open Source Day

Comments

@ShreyaPrasad1209
Copy link
Member

Describe the bug

The dark mode toggle has "Edit on GitHub" written on it instead of "Dark Mode". This can confuse many users as they might assume it to be a link to GitHub.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://docs.circuitverse.org/#/'
  2. Click on 'Edit on GitHub' on top right
  3. You will see it is a dark mode toggler

Expected behavior

Change name of "Edit on GitHub" to "Dark Mode".

Screenshot

image

Device Information [optional]:

  • OS: Windows 10
  • Browser: Edge

Are you working on this issue? (Yes/No)

No this issue is reserved for Open Source Day participants.
@ShreyaPrasad1209 ShreyaPrasad1209 added the good first issue Good for newcomers label Jun 21, 2021
@ShreyaPrasad1209 ShreyaPrasad1209 added this to To Do Issues in Open Source Day Jun 24, 2021
@StarTrooper08
Copy link

I guess 'Edit on GitHub' is a link for contributing to that webpage on GitHub. Do we have to mention somewhere around the toggle about the dark and light mode?

@deepxcode
Copy link

@ShreyaPrasad1209 Can you assign this to me?

@vvijayalakshmi21
Copy link

Hi,
I am interested to take this up.
Just to clarify - the edit link does take us to github page. Should this be retained along with introducing a new label for Dark Mode or can I just remove the edit link and just include the dark mode label in there?

@labbasaiteja
Copy link

Is this issue available I am interested to take up?

@dineshkumar12004
Copy link

hey can i work on this for OSD, I couldn't make it that time ?

@Kartikay304
Copy link
Member

i would like to work on this issue

@ShreyaPrasad1209
Copy link
Member Author

@Kartikay304 sure

@Kartikay304
Copy link
Member

@Kartikay304 sure

Thanks, I guess the edit link does take us to github page. Should this be retained along with introducing a new label for Dark Mode or can I just remove the edit link and just include the dark mode label in there?

@Kartikay304 Kartikay304 linked a pull request Sep 7, 2021 that will close this issue
Open
6 tasks
@PaarthAgarwal
Copy link

hey @ShreyaPrasad1209, can you please assign this issue to me?

@Adarsh9306
Copy link

Hey @ShreyaPrasad1209 if this issue is still open can you please assign it to me??

@chiragmalik2612
Copy link

can you please assign it to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Open Source Day
To Do Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Darkmode fix#298 Kartikay304/CircuitVerseDocs
10 participants
@deepxcode @vvijayalakshmi21 @Kartikay304 @ShreyaPrasad1209 @labbasaiteja @dineshkumar12004 @StarTrooper08 @PaarthAgarwal @Adarsh9306 @chiragmalik2612