Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode fix#298 #309

Open
wants to merge 2 commits into
base: documentation_revamp
Choose a base branch
from
Open

Darkmode fix#298 #309

wants to merge 2 commits into from

Conversation

Kartikay304
Copy link
Member

@Kartikay304 Kartikay304 commented Sep 7, 2021 •
edited

Fixes #298

Changes done:

  • Changed the label from "Edit on Github" to "Toggle Dark Mode"
  • Removed on click property ,which was responsible for label to redirect to Github.

Screenshots:

Before -
before

After -
after

Preview Link(s):

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one
    @ShreyaPrasad1209, Will you please take a look at my PR :-).

@ShreyaPrasad1209
Copy link
Member

@tachyons is it wise to edit the docs theme?

@tachyons
Copy link
Member

No, we may have to fix in upstream

@Kartikay304
Copy link
Member Author

No, we may have to fix in upstream

Then will you tell me which file I need to edit, as I am not able to find any other .css file in current repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tachyons tachyons Awaiting requested review from tachyons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong label on dark mode toggler
3 participants
@Kartikay304 @ShreyaPrasad1209 @tachyons