Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode gets switched off after refreshing the page #221

Open
1 task done
animesh-007 opened this issue May 13, 2020 · 5 comments · Fixed by #224 · May be fixed by #240
Open
1 task done

Dark mode gets switched off after refreshing the page #221

animesh-007 opened this issue May 13, 2020 · 5 comments · Fixed by #224 · May be fixed by #240
Assignees
@animesh-007
Labels
dark mode context related to dark mode in particular only

Comments

@animesh-007
Copy link
Contributor

I am submitting a -

  • [] Feature Request
  • Bug Report

Describe your bug/feature -

Dark mode gets switched off after refreshing the page rather it should retain its value after refreshing.

Current behaviour -

Dark mode gets switched off after refreshing the page.

Expected behavior -

It should retain its previous value after refreshing.

Screenshots (if relevant) -

Are you working on this issue? (Yes/No)

yes
@YashKumarVerma YashKumarVerma added the dark mode context related to dark mode in particular only label May 15, 2020
@animesh-007 animesh-007 mentioned this issue May 16, 2020
Merged
@YashKumarVerma YashKumarVerma mentioned this issue May 25, 2020
Closed
YashKumarVerma pushed a commit that referenced this issue May 26, 2020
@animesh-007
darkmode retains after refresh Fixes #221
766b887
@ShubhankarKG
Copy link
Contributor

This needs to reopened. I guess I'm seeing a few anomalies due to localStorage here.

Screenshot_20200526-135222
Screenshot_20200526-135215
Screenshot_20200526-135148
Screenshot_20200526-135130
Screenshot_20200526-143801

This looks like a problem with localStorage. Please reopen the issue @YashKumarVerma

@YashKumarVerma
Copy link
Member

This looks like a problem with localStorage. Please reopen the issue @YashKumarVerma

@schezfaz @Shivansh2407 @animesh-007 can you confirm.

  • check on incognito to reset local configs.

@Shivansh2407
Copy link
Member

The dark mode in incognito does not switches back to light mode on refresh but the toggle button does switch back to normal.

@ShubhankarKG
Copy link
Contributor

The toggle works independently now. It sets back on every route.

@YashKumarVerma
Copy link
Member

The dark mode in incognito does not switches back to light mode on refresh but the toggle button does switch back to normal.

@ShubhankarKG ShubhankarKG linked a pull request May 26, 2020 that will close this issue
Open
6 tasks
CapTen101 pushed a commit to CapTen101/CircuitVerseDocs that referenced this issue Jun 23, 2020
@animesh-007 @CapTen101
darkmode retains after refresh Fixes CircuitVerse#221
3c62c49
pranay-simejia added a commit to pranay-simejia/CircuitVerseDocs that referenced this issue Mar 26, 2021
@pranay-simejia
[fix] CircuitVerse#221 dark mode
85e8e2f
tachyons pushed a commit that referenced this issue Dec 20, 2021
@pranay-simejia @tachyons
[fix] #221 dark mode
a107480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@animesh-007 animesh-007

Labels
dark mode context related to dark mode in particular only
Projects
None yet
Milestone
No milestone
4 participants
@YashKumarVerma @Shivansh2407 @ShubhankarKG @animesh-007