Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new contributors section #233

Closed
wants to merge 1 commit into from

Conversation

ShubhankarKG
Copy link
Contributor

Fixes #230

Changes done:

  • Removed contributor tags from all pages that had it earlier, and created a new contributors page along with the contributors graph.

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

@ShubhankarKG
Copy link
Contributor Author

@YashKumarVerma
Copy link
Member

@ShubhankarKG
Copy link
Contributor Author

Thats a problem already. Issue #231 has that mentioned. Meanwhile, this'll work :-
https://deploy-preview-233--wizardly-perlman-2ed351.netlify.app
Then navigate to Contributors section

Copy link
Member

@nitin10s nitin10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change the section name to "About" and not "Contributors"
  2. Remove the subsections.
  3. Remove the links from subheadings CircuitVerse and Contributors.
  4. The Contributors' Github profile should open on clicking?

docs/contributors.md Outdated Show resolved Hide resolved
Refactored content
@ShubhankarKG
Copy link
Contributor Author

Changes made. The contribution graph works in that way only. It redirects to the contributions made by everyone and not one specific person. This is the same as that in the Interactive Book.

@ShubhankarKG
Copy link
Contributor Author

Screenshot from 2020-05-23 21-03-40

New About Page.

Copy link
Member

@nitin10s nitin10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @satu0king @tachyons please check once and merge.

@ShubhankarKG
Copy link
Contributor Author

Looks like this hasn't gone in yet 🤣 Let me know if these changes don't match something and I'll fix that up, while also re-re-requesting a review from @satu0king @tachyons.

@@ -2,8 +2,6 @@

> This guide will teach you how to use the decoders and plexers available on Circuitverse.

Contributing Authors: [@brahmakulkarni](https://github.com/brahmakulkarni)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove contributing author names from each file. @Shivansh2407 @sal2701 what do you say? Should we keep them.

Copy link
Member

@sal2701 sal2701 Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satu0king Yeah I agree, individual page contributors look good since they are technically authors and not code contributors, and we can trace back for any queries or clarifications. We could add the photo instead of the names like before.

Since the main issue was missing user's we could add the contributors displayed on GitHub above each file. Like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove contributors tag from docs
5 participants