New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new contributors section #233
Conversation
broken |
Thats a problem already. Issue #231 has that mentioned. Meanwhile, this'll work :- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Change the section name to "About" and not "Contributors"
- Remove the subsections.
- Remove the links from subheadings CircuitVerse and Contributors.
- The Contributors' Github profile should open on clicking?
Refactored content
c5aafac
to
24ec0cf
Compare
Changes made. The contribution graph works in that way only. It redirects to the contributions made by everyone and not one specific person. This is the same as that in the Interactive Book. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @satu0king @tachyons please check once and merge.
Looks like this hasn't gone in yet 🤣 Let me know if these changes don't match something and I'll fix that up, while also re-re-requesting a review from @satu0king @tachyons. |
@@ -2,8 +2,6 @@ | |||
|
|||
> This guide will teach you how to use the decoders and plexers available on Circuitverse. | |||
|
|||
Contributing Authors: [@brahmakulkarni](https://github.com/brahmakulkarni) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should remove contributing author names from each file. @Shivansh2407 @sal2701 what do you say? Should we keep them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satu0king Yeah I agree, individual page contributors look good since they are technically authors and not code contributors, and we can trace back for any queries or clarifications. We could add the photo instead of the names like before.
Since the main issue was missing user's we could add the contributors displayed on GitHub above each file. Like this
Fixes #230
Changes done:
✅️ By submitting this PR, I have verified the following