Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: "app/views/about/index.html.erb" #4829

Open
Durgesh4993 opened this issue Mar 18, 2024 · 0 comments · May be fixed by #4830
Open

Feature: "app/views/about/index.html.erb" #4829

Durgesh4993 opened this issue Mar 18, 2024 · 0 comments · May be fixed by #4830

Comments

@Durgesh4993
Copy link

Is your feature request related to a problem? Please describe

There are a few potential issues and improvements:

Error Handling: You might want to add error handling to your asynchronous functions (fetch and json()). This ensures that if there's an issue with the network request or parsing JSON, your code can handle it gracefully.

HTML Structure: Ensure that you have an element with the class about-contributors-section in your HTML where you want to append the contributor avatars.

Async/Await in Loops: The await keyword inside a loop may not be efficient if each iteration depends on the previous one. Consider using Promise.all() to make the requests concurrently.

Describe the solution you'd like

This code includes error handling for fetch requests, improves efficiency by using Promise.all() to fetch contributors concurrently, and assumes there's an HTML element with the class about-contributors-section where contributor avatars will be appended.

Describe alternatives you've considered

No response

Additional context

No response

Are you working on this?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant