Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips for social-media icons and styling of contact link #125

Open
bhutani2002 opened this issue Feb 8, 2022 · 11 comments
Open

Tooltips for social-media icons and styling of contact link #125

bhutani2002 opened this issue Feb 8, 2022 · 11 comments

Comments

@bhutani2002
Copy link

Describe the problem
In the "Footer" section of the "Blog" Webpage, all the four social media icons doesn't look descriptive. Adding the Tooltips to each of the icons will enhance the effect of the icons and it will be easy to recognize them. The "Contact" link in between of the footer doesn't look well styled.

To Reproduce
Steps to reproduce the behavior:

Go to https://blog.circuitverse.org/
Scroll down to the "Footer"
See error

Expected behavior
To create tooltips for each of the social-media icons and changing the font styles and position for "Contact Link"

Screenshots

CircuitVerse-Blog-Footer

Are you working on this issue? (Yes/No)
Yes

@bhutani2002
Copy link
Author

Hey @gr455 , please try to review it once and provide me a feedback so that I can generate a pull request. Thank You.

@gr455
Copy link
Member

gr455 commented Feb 10, 2022

@bhutani2002 Can you tell me what files you made the changes to?

@bhutani2002
Copy link
Author

@bhutani2002 Can you tell me what files you made the changes to?
themes/northerndlab-hugo/layouts/partials/footer.html
and
themes/northerndlab-hugo/static/plugins/boot-strap/bootstrap.min.css
I guess these were the two files!

image

@bhutani2002
Copy link
Author

@bhutani2002 Can you tell me what files you made the changes to?

I guess I should rather create a pull request as the issue I guess is fine now, as you will also get to see the changes in them. So, if you allow I can.

@gr455
Copy link
Member

gr455 commented Feb 10, 2022

Yeah that's not our repository. That is another repository which we have cloned from https://github.com/gethugothemes/northendlab-light/

@bhutani2002
Copy link
Author

Yeah that's not our repository. That is another repository which we have cloned from https://github.com/gethugothemes/northendlab-light/

So, can I push in this repo?? Because this is the submodule in this repo . So, this will enhance the changes in this repo and abviously be seen in the blog page.

@gr455
Copy link
Member

gr455 commented Feb 10, 2022

I think it should be fine, I am not sure if we have done that in the past, but I don't see any problem with that

PS: Sorry about my lack of knowledge with submodules 😅

@bhutani2002
Copy link
Author

Okay, sure...because I too had 1 or 2 more issues planned for this repo....and I guess that must be from this repo.
So I will push it for now. And can you tell me who checks merges the code for this blog repo of CircuitVerse.

@bhutani2002
Copy link
Author

I think it should be fine, I am not sure if we have done that in the past, but I don't see any problem with that

PS: Sorry about my lack of knowledge with submodules 😅

No issues, not a problem. Thanks for your inputs. I have tagged you in the primary CircuitVerse Issue section as well , to just review my issue so that I can complete the task.

@bhutani2002
Copy link
Author

I think it should be fine, I am not sure if we have done that in the past, but I don't see any problem with that

PS: Sorry about my lack of knowledge with submodules 😅

So, who can help me on that?? Can you please tell me....Because as I made changes in the theme its also not getting added for commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants