Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in source samplers #32

Open
ConnorStoneAstro opened this issue Apr 28, 2023 · 1 comment
Open

Built-in source samplers #32

ConnorStoneAstro opened this issue Apr 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ConnorStoneAstro
Copy link
Member

For prototyping it would be useful to have a caustic built-in system to sample reasonable source images. The github could store the PROBES sample and there could be a method in caustic to draw a random PROBES galaxy. This would download an HDF5 file (first time its called) with the PROBES sample, then randomly select one, and sample it at the desired resolution.

@ConnorStoneAstro ConnorStoneAstro added the enhancement New feature or request label Apr 28, 2023
@adam-coogan
Copy link
Collaborator

I'd recommend using the functionality already built into torch for this kind of thing: in particular Datasets for storing the data and DataLoaders for iterating through the data in various ways. And actually, I've already written one for HDF5 files as well as PROBES and Illustris-specific datasets that should cover a fair chunk of what's needed.

The main missing piece compared to what you're suggesting is downloading functionality. For consistency, I'd take a look at the MNIST dataset in torchvision, which has an init argument indicating whether or not to download the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants