Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SystemSettings for Other Settings #1905

Closed
crossan007 opened this issue Feb 11, 2017 · 1 comment · Fixed by #7027
Closed

Use SystemSettings for Other Settings #1905

crossan007 opened this issue Feb 11, 2017 · 1 comment · Fixed by #7027
Assignees

Comments

@crossan007
Copy link
Contributor

"iPDFOutputType","googleTrackingID"

@crossan007
Copy link
Contributor Author

iPDFOutputType requires some additional work - some of the report classes are still referencing the VAR directly, rather than accessing via SystemConfigs

@crossan007 crossan007 modified the milestone: Backlog Jul 14, 2017
@DawoudIO DawoudIO removed this from the Backlog milestone Nov 1, 2023
respencer added a commit to respencer/ChurchCRM that referenced this issue May 13, 2024
@respencer respencer self-assigned this May 14, 2024
DAcodedBEAT added a commit that referenced this issue May 16, 2024
# Description & Issue number it closes 
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. -->

Resolves #1905

## Screenshots (if appropriate)
<!-- Before and after --> 
None

## How to test the changes?

No change should be detected.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# How Has This Been Tested?

<!-- Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce. Please also list any relevant
details for your test configuration -->

Visual inspection.

# Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants