Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Person editor not showing full content. #7026

Open
romdricks opened this issue May 13, 2024 · 19 comments · Fixed by #7034
Open

Bug: Person editor not showing full content. #7026

romdricks opened this issue May 13, 2024 · 19 comments · Fixed by #7034
Assignees
@respencer
Labels
status: needs information Further information is requested

Comments

@romdricks
Copy link
Contributor

romdricks commented May 13, 2024 •
edited

Description

I have 49 persons in the database. 47 of them doesn't show the full content in Person Editor. This occurs when setting the bHidePersonAddress to false in PeopleSetup

  • ChurchCRM version: 5.7.0
  • PHP version the server running: PHP 8.1
  • DB Server and Version the server is running: MySQL

Screenshots and/or logs

Screenshot 2024-05-13 162052
@romdricks romdricks added the bug label May 13, 2024
@DawoudIO
Copy link
Contributor

Do you have errors in the logs

@romdricks
Copy link
Contributor Author

Here is the screenshot:
Screenshot 2024-05-14 125844

@romdricks
Copy link
Contributor Author

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297
Stack trace:
#0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName()
#1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...')
#2 {main}
thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

@DAcodedBEAT
Copy link
Contributor

@romdricks

47 of them doesn't show the full content in Person Editor.

What are you expecting to see?

@DAcodedBEAT DAcodedBEAT mentioned this issue May 17, 2024
Merged
@DAcodedBEAT DAcodedBEAT added the status: needs information Further information is requested label May 17, 2024
@romdricks
Copy link
Contributor Author

@romdricks

47 of them doesn't show the full content in Person Editor.

What are you expecting to see?

Person-Editor

@respencer
Copy link
Contributor

Most of those fields should be hidden when the person is part of a family, and are on the current build.

What does the associated family record look like for those empty fields?

Screenshot 2024-05-17 at 20-44-48 ChurchCRM Person Editor

DAcodedBEAT added a commit that referenced this issue May 17, 2024
@DAcodedBEAT
add update person tests to ensure functionality (#7034)
66a0b74 
# Description & Issue number it closes 
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. -->

I was hoping to resolve #7026 but I didn't see the error, so I'm adding
tests to update a created person to ensure functionality
@DAcodedBEAT DAcodedBEAT reopened this May 17, 2024
@romdricks
Copy link
Contributor Author

Please compare my screenshots and you will notice that the page doesn't fully load; it's cut off.

@romdricks
Copy link
Contributor Author

@DAcodedBEAT @respencer I was doing some testing and I think i found the issue. I realized setting the bHidePersonAddress to false in PeopleSetup would cause the issue mentioned.

@respencer respencer removed the bug label May 20, 2024
@respencer
Copy link
Contributor

That's expected behavior then. If someone is part of a family the system expects you to use the family address.

@romdricks
Copy link
Contributor Author

romdricks commented May 20, 2024 •
edited

That's expected behavior then. If someone is part of a family the system expects you to use the family address.

Ok. But shouldn't the whole page load with the rest of the content (contact info, membership info, custom fields etc..) and save, save-and-add, and cancel buttons? The footer doesn't load either. The page looks exactly as in the screenshot.

@respencer
Copy link
Contributor

respencer commented May 20, 2024 •
edited

Okay, that would require further investigation.

The thing is I'm currently unable to recreate this issue, so it makes isolating it more difficult. Will make a further attempt to narrow it down.

@romdricks
Copy link
Contributor Author

okay. thank you.

@respencer
Copy link
Contributor

I originally meant to say "unable" (now edited).

@respencer
Copy link
Contributor

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

@respencer respencer self-assigned this May 21, 2024
@romdricks
Copy link
Contributor Author

romdricks commented May 21, 2024 •
edited

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

@respencer
Copy link
Contributor

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

Okay, that makes no sense then. Null in this context means empty, so the error is that there is no country specified.

Will continue to investigate when I have time.

@romdricks
Copy link
Contributor Author

[14-May-2024 19:34:12 America/Jamaica] PHP Fatal error: Uncaught TypeError: ChurchCRM\data\Countries::getCountryByName(): Argument #1 ($CountryName) must be of type string, null given, called in /home/.../public_html/churchcrm/Include/StateDropDown.php on line 14 and defined in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php:297 Stack trace: #0 /home/.../public_html/churchcrm/Include/StateDropDown.php(14): ChurchCRM\data\Countries::getCountryByName() #1 /home/.../public_html/churchcrm/PersonEditor.php(904): require('/home/...') #2 {main} thrown in /home/.../public_html/churchcrm/ChurchCRM/data/Countries.php on line 297

Out of curiosity, why did you add an address with no country?

Country was added along with zip code, state etc...

Okay, that makes no sense then. Null in this context means empty, so the error is that there is no country specified.

Will continue to investigate when I have time.

Ok thank you.

@DAcodedBEAT
Copy link
Contributor

@romdricks is this still an issue on 5.8.0 ?

@romdricks
Copy link
Contributor Author

romdricks commented May 31, 2024 •
edited

@romdricks is this still an issue on 5.8.0 ?

Only when setting the bHidePersonAddress to false in PeopleSetup. I will add it to the description. I am using true now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@respencer respencer

Labels
status: needs information Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add update person tests to ensure functionality ChurchCRM/CRM
4 participants
@respencer @DawoudIO @DAcodedBEAT @romdricks