Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use securityRedirect whenever we redirect because of a missing user role #6975

Open
DAcodedBEAT opened this issue Apr 30, 2024 · 0 comments
Open

Enhancement: Use securityRedirect whenever we redirect because of a missing user role #6975

DAcodedBEAT opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement good first issue Indicates a good issue for first-time contributors

Comments

@DAcodedBEAT
Copy link
Contributor

Description

A clear and concise description of what the reported bug is:

Uncovered in #6969 - we have many places where we just redirect without setting the reason, which might cause users to be confused as to why they cannot reach the pages they need to. Reevaluate where we use redirect and see if securityRedirect is more applicable.

  • ChurchCRM version: [e.g. 5.4.3] 5.8.0
  • PHP version the server running: [e.g. PHP 8.2.13] N/A
  • DB Server and Version the server is running: [e.g. MariaDB 11.4, MySQL 8.2] N/A
@DAcodedBEAT DAcodedBEAT mentioned this issue Apr 30, 2024
Merged
12 tasks
@DAcodedBEAT DAcodedBEAT added the good first issue Indicates a good issue for first-time contributors label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Indicates a good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DAcodedBEAT