Bug: Provide better checks and error reporting if Photo dirs are not writeable

[grayeul]

Description

File permissions are tricky because this code can be run in a number of different environments, as different users, in both development and production mode. Better checks are needed, followed by better error reporting when there are problems with writeable files or directories. This particular issue is to address the problems in the Photo management area, which tries to create/update photos and thumbnails.

• ChurchCRM version: 5.5.0
• PHP version the server running: PHP 5.1
• DB Server and Version the server is running: Mariadb 10.3.39

Steps To Reproduce

The errors are seen if the src/Images/{Person,Family} and 'thumbnails' directory in each of those are not writeable. The errors generated in this case are not obvious.

Expected behavior

Ideally an unwriteable file or directory would generate a meaningful error, at least in the logs, if not on screen.

Screenshots and/or logs

📋 Relevant screenshots:

N/A

📋 Logs:

N/A

Desktop (please complete the following information):

• OS and Version: RockyLinux 8.9
• Browser (and Version): Firefox 115.6.0esr (64-bit)

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[respencer]

There is a warning shown in /v2/admin/debug near the bottom of that page:

CRM/src/ChurchCRM/Service/AppIntegrityService.php

Lines 143 to 148 in da27702

	private static function testImagesWriteable(): bool
	{
	return is_writable(SystemURLs::getDocumentRoot() . '/Images/') &&
	is_writable(SystemURLs::getDocumentRoot() . '/Images/Family') &&
	is_writable(SystemURLs::getDocumentRoot() . '/Images/Person');
	}

How exactly would you like it to be handled differently?

[DAcodedBEAT]

There is a warning shown in /v2/admin/debug near the bottom of that page:

CRM/src/ChurchCRM/Service/AppIntegrityService.php

Lines 143 to 148 in da27702

	private static function testImagesWriteable(): bool
	{
	return is_writable(SystemURLs::getDocumentRoot() . '/Images/') &&
	is_writable(SystemURLs::getDocumentRoot() . '/Images/Family') &&
	is_writable(SystemURLs::getDocumentRoot() . '/Images/Person');
	}

How exactly would you like it to be handled differently?

https://github.com/ChurchCRM/CRM/blob/master/src/ChurchCRM/dto/Photo.php#L192-L197 I believe this should check for is_dir and is_writable and if not, emit a log for each error condition