-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Option to add "States" in DB #6869
Comments
third alternative which might be a good idea to consider - make the application no longer directly aware of states and instead call to an API for this data, as ISO3166-2 (subdivision/state/province) data is constantly changing |
@DAcodedBEAT Just seeing this. The idea sounds good to me. How would you go about implementing this? |
As long as the API is still local, I'm not fussed where the data is populated from. However, introducing external dependancies (like real-time polling of some random web service living out on the internet) could create a whole new set of headaches for support. Just something to consider. |
Thing is that kind of information changes regularly. If you don't want an external (online) source, are we going to attempt to get some life back into something like this? |
This one seems to have more life in it, not sure about their scrapping of Wikipedia though: |
It doesn't seem to understand language, so the data gets all mixed up. When I checked it out it didn't even have all the South African Provinces in English. |
Logged an issue: |
@respencer can you check this one as well. |
Thank you. Looks promising. Unfortunately it doesn't currently come with Afrikaans as a locale, still worth keeping an eye one though. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Is there any progress on this? |
Unfortunately not, time is not on my side right now. Will try to look at this further when I have time. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Is your feature request related to a problem? Please describe.
If you don't live in Australia, Canada, or the USA, you get a useless state drop down selector.
Describe the solution you'd like
As suggested by @grayeul in a PM there should be both the states in their JSON files to seed the system, and there should be an option to add states (counties, provinces, etc.) to the DB for those countries without a JSON file.
Describe alternatives you've considered
Every country has it's own JSON file. Doable, but a more ambitious goal. And it needs to be separated from the language selector as mention in: #6868
Additional context
The text was updated successfully, but these errors were encountered: