Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recount::snaptron_query() is broken on BioC 3.16 and 3.17 #17

Open
lcolladotor opened this issue Feb 20, 2023 · 1 comment
Open

recount::snaptron_query() is broken on BioC 3.16 and 3.17 #17

lcolladotor opened this issue Feb 20, 2023 · 1 comment

Comments

@lcolladotor
Copy link

Hi,

Currently all snaptron-related tests at recount are failing. That is, https://github.com/leekgroup/recount/blob/7301c5fc09c968110d50617eef43a635b03fd4a2/tests/testthat/test-data.R#L176-L201.

Here's part of the output.

master* > snap <- snaptron_query(junctions)
2023-02-20 13:56:55 querying Snaptron
2023-02-20 13:56:55 processing results
2023-02-20 13:56:55 found no exon-exon junctions in Intropolis version srav1 matching your query: this version uses hg19 coordinates.
master* > snap_v2 <- snaptron_query(junctions_v2, version = "srav2")
2023-02-20 13:57:08 querying Snaptron
2023-02-20 13:57:08 processing results
2023-02-20 13:57:08 found no exon-exon junctions in Intropolis version srav2 matching your query: this version uses hg38 coordinates.
master* > snap_gtex <- snaptron_query(junctions_v2, version = "gtex")
2023-02-20 13:57:11 querying Snaptron
2023-02-20 13:57:11 processing results
2023-02-20 13:57:11 found no exon-exon junctions in Intropolis version gtex matching your query: this version uses hg38 coordinates.
master* > snap_tcga <- snaptron_query(junctions_v2, version = "tcga")
2023-02-20 13:57:12 querying Snaptron
2023-02-20 13:57:12 processing results
2023-02-20 13:57:12 found no exon-exon junctions in Intropolis version tcga matching your query: this version uses hg38 coordinates.
master* >     expect_equal(length(snap), 3)
Error: length(snap) not equal to 3.
1/1 mismatches
[1] 0 - 3 == -3

Maybe the syntax of snaptron changed and I need to update https://github.com/leekgroup/recount/blob/master/R/snaptron_query.R.

I don't think that this is related to the IDIES / AWS switch (which impacted leekgroup/recount#23). It's likely related to Stingray's move to IDIES.

Best,
Leo

lcolladotor added a commit to leekgroup/recount that referenced this issue Feb 20, 2023
…lks/snaptron#17. Also #23. I tried insulating recount from these tests, so they'll be reported as warnings instead of errors on the BioC build machines for now.
lcolladotor added a commit to leekgroup/recount that referenced this issue Feb 20, 2023
…lks/snaptron#17. Also #23. I tried insulating recount from these tests, so they'll be reported as warnings instead of errors on the BioC build machines for now.
@lcolladotor
Copy link
Author

Hi,

I just wanted to make a note that this still seems to be an issue with BioC 3.19.

Best,
Leo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant