Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom properties doesn't work with optgroup #840

Open
cedbesafilm opened this issue Mar 15, 2020 · 4 comments · May be fixed by #822
Open

Custom properties doesn't work with optgroup #840

cedbesafilm opened this issue Mar 15, 2020 · 4 comments · May be fixed by #822
Labels
bug

Comments

@cedbesafilm
Copy link

cedbesafilm commented Mar 15, 2020 •
edited

Describe the bug
When the user click on an option inside an optgroup tag, the data-custom-properties attribute is ignored and the customProperties is set to null

To Reproduce
HTML without optgroup

<select id="um1" class="gybesa-select ricercaOn   mt-2">
  <option placeholder value="">----------</option>
  <option value="m" data-custom-properties="m<split>metri<split>Y<split>lunghezza">metri</option>
  <option value="dm" data-custom-properties="dm<split>decimetri<split>Y<split>lunghezza">decimetri</option>
  <option value="cm" data-custom-properties="cm<split>centimetri<split>Y<split>lunghezza">centimetri</option>
  <option value="mm" data-custom-properties="mm<split>millimetri<split>Y<split>lunghezza">millimetri</option>
  <option value="µm" data-custom-properties="µm<split>micron<split>Y<split>lunghezza">micron</option>
  <option value="kg" data-custom-properties="kg<split>chilogrammo<split>Y<split>peso">chilogrammo</option>
  <option value="hg" data-custom-properties="hg<split>ettogrammo<split>Y<split>peso">ettogrammo</option>
  <option value="dag" data-custom-properties="dag<split>decagrammo<split>Y<split>peso">decagrammo</option>
  <option value="g" data-custom-properties="g<split>grammo<split>Y<split>peso">grammo</option>
  <option value="nr" data-custom-properties="nr<split>numero<split>Y<split>quantita">numero</option>
  <option value="pz" data-custom-properties="pz<split>pezzi<split>Y<split>quantita">pezzi</option>
  <option value="ban" data-custom-properties="ban<split>bancali<split>Y<split>quantita">bancali</option>
  <option value="bob" data-custom-properties="bob<split>bobine<split>Y<split>quantita">bobine</option>
</select>

when i select an option i can retrieve customProperties
image

if i enable optgroup

<select id="um1" class="gybesa-select ricercaOn   mt-2">
  <option placeholder value="">----------</option>
  <optgroup label="lunghezza">
    <option value="m" data-custom-properties="m<split>metri<split>Y<split>lunghezza">metri</option>
    <option value="dm" data-custom-properties="dm<split>decimetri<split>Y<split>lunghezza">decimetri</option>
   <option value="cm" data-custom-properties="cm<split>centimetri<split>Y<split>lunghezza">centimetri</option>
    <option value="mm" data-custom-properties="mm<split>millimetri<split>Y<split>lunghezza">millimetri</option>
    <option value="µm" data-custom-properties="µm<split>micron<split>Y<split>lunghezza">micron</option>
  </optgroup>
  <optgroup label="peso">
    <option value="kg" data-custom-properties="kg<split>chilogrammo<split>Y<split>peso">chilogrammo</option>
    <option value="hg" data-custom-properties="hg<split>ettogrammo<split>Y<split>peso">ettogrammo</option>
    <option value="dag" data-custom-properties="dag<split>decagrammo<split>Y<split>peso">decagrammo</option>
    <option value="g" data-custom-properties="g<split>grammo<split>Y<split>peso">grammo</option>
    </optgroup>
  <optgroup label="quantita">
    <option value="nr" data-custom-properties="nr<split>numero<split>Y<split>quantita">numero</option>
    <option value="pz" data-custom-properties="pz<split>pezzi<split>Y<split>quantita">pezzi</option>
    <option value="ban" data-custom-properties="ban<split>bancali<split>Y<split>quantita">bancali</option>
    <option value="bob" data-custom-properties="bob<split>bobine<split>Y<split>quantita">bobine</option>
  </optgroup>
</select>

when i select an option i can't retrieve customProperties
image

I have try to add another optgroup for the placeholder option but with no luck

Expected behavior
Even with optgroup retrieve data-custom-properties attribute
@kroehre
Copy link

kroehre commented Jul 24, 2020

@cedbesafilm did you find a solution? I think I'm encountering this issue as well.

@cedbesafilm
Copy link
Author

@kroehre
I hadn't found a solution. But since I used optgroup for an aesthetic factor I directly eliminated optgroup to simplify the code

@marcus-at-localhost
Copy link

A fix exists: #543

@marcus-at-localhost
Copy link

optgroup could be replaced by <option disabled>%s</option> to have a visual separation. It's not as nice though....

@mtriff mtriff linked a pull request Dec 22, 2021 that will close this issue
Fix customProperties for optgroup options #822
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix customProperties for optgroup options Zilus/Choices
3 participants
@kroehre @marcus-at-localhost @cedbesafilm