Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/plugins): add getUser to helpers #6358

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Apr 26, 2024

Description

Let plugins access the user object.

Questions

  • I wasn't sure how to handle the plugin helpers for the standalone version, so I set it to unimplemented.
  • Should getUser return ServerMyUserModel instead of AuthUser? By doing that the methods in AuthUser doesn't need to be a part of the public API.

Related issues

closes #6355

Has this been tested?

  • 馃憤 yes, I added tests to the test suite
  • 馃挱 no, because this PR is a draft and still needs work
  • 馃檯 no, because this PR does not update server code
  • 馃檵 no, because I need help

There's no test suites for the client.

@kontrollanten
Copy link
Contributor Author

I don't know why all checks are failing, it seems unrelated to my changes?

Let plugins access the user object.

closes Chocobozzz#6355
Avoid exposing AuthUser as external API.
@kontrollanten
Copy link
Contributor Author

Solved it with 8e2d1e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give plugins access to user object on the client
1 participant