Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing vids between 1080p => 2159p are reset to 1080p #6350

Open
spirillen opened this issue Apr 23, 2024 · 13 comments
Open

importing vids between 1080p => 2159p are reset to 1080p #6350

spirillen opened this issue Apr 23, 2024 · 13 comments
Labels
Status: Waiting for answer Waiting issue author answer

Comments

@spirillen
Copy link

Describe the problem to be solved

If you upload a video that is more than 1080p but not 2160p, it is only hosted as a 1080p,

Here is 3 examples. The first one stick to 2160p as supposed, number 2 and tree are downsized to 1080p

  1. https://www.youtube.com/watch?v=5DuZkK_trYY
  2. https://www.youtube.com/watch?v=D2KE2a5qo0g
  3. https://www.youtube.com/watch?v=iqYK79jCssA

Describe the solution you would like

shouldn't the video then be hosted as a 2160Ip video?

@spirillen
Copy link
Author

OH, when trying to import then via videos/upload#import-url number two and tree was downsixed to 480p

@spirillen
Copy link
Author

spirillen commented Apr 23, 2024

Screenshots to show the situation

image

image

image

@Chocobozzz
Copy link
Owner

HI,

Have you enabled the "original resolution transcoding" option (https://docs.joinpeertube.org/admin/configuration#resolutions)?

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Apr 25, 2024
@spirillen
Copy link
Author

HI,

Have you enabled the "original resolution transcoding" option (https://docs.joinpeertube.org/admin/configuration#resolutions)?

No, as I have experienced significant bad results by doing it.

@Chocobozzz
Copy link
Owner

No, as I have experienced significant bad results by doing it.

What do you mean by "bad results"?

@spirillen
Copy link
Author

Some really corny videos. Another thing I come to think of, I should have mentioned previously, is why should you want to re-encode a already correctly formatted video?

My suggestion then become to also read the width of the imported video, as the high differ depending on the video scale 16:9|10:9|4:3 etc, but as the width is as little a constant... ie. as above links, I suggest to build the rule to say if bigger than, then accept it as equal next size

Example

3240x1556 would be accepted as 3841x2160 as it is bigger than 1920x1080

@SimplyCorbett
Copy link

What do you mean by corny videos?

@spirillen
Copy link
Author

spirillen commented May 4, 2024

seriously bad quality, think of a video clip recorded on mobile phone from the 90's; now scaled up and down 50 times, getting the picture.. or rather you won't 😏

@SimplyCorbett
Copy link

seriously bad quality, think of a video clip recorded on mobile phone from the 90's; now scaled up and down 50 times, getting the picture.. or rather you won't 😏

You understand that peertube was designed to run on cheap VPS in the 2 core range correct? It's designed for everyone to run.

If you want better video quality you need to use custom transcoding settings. I recommend the transcoding-profile-debug plugin.

Your CPU usage is going to skyrocket and your server needs to be able to support the new hardware requirements.

I too wish the design of peertube explained this better and had quality options built right into it. I also wish the remote runners were designed with custom transcoding settings in mind.

It does not however.

Anywho, my point is peertube -can- give you good quality videos if you tweak a few things. Good luck.

@SimplyCorbett
Copy link

Some really corny videos. Another thing I come to think of, I should have mentioned previously, is why should you want to re-encode a already correctly formatted video?

Because videos are encoded in HLS which is the core of peertube and what makes P2P work.

Peertube is not YouTube.

@spirillen
Copy link
Author

Peertube is not YouTube.

Thanks god, I hope not 😄

I recommend the transcoding-profile-debug plugin.

Do you have a link to the documentation for this? and yes, the box have a bit more than 2 vCore's 😉

@SimplyCorbett
Copy link

Peertube is not YouTube.

Thanks god, I hope not 😄

I recommend the transcoding-profile-debug plugin.

Do you have a link to the documentation for this? and yes, the box have a bit more than 2 vCore's 😉

https://pastebin.com/TdVBPUfd

@SimplyCorbett
Copy link

SimplyCorbett commented May 6, 2024

I would also take a good look at the source code for yt-dlp downloads and make sure it’s downloading and prioritizing the highest quality version available. I’ve had to change that in the past on prior versions.

I’m planning on messing around with peertube again soon my site has been on pause for a while now.

Edit:

@spirillen https://github.com/Chocobozzz/PeerTube/blob/develop/server/core/helpers/youtube-dl/youtube-dl-cli.ts lines 86-104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for answer Waiting issue author answer
Projects
None yet
Development

No branches or pull requests

3 participants