Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More discreet "Incompatible browser" message #6284

Open
kontrollanten opened this issue Mar 22, 2024 · 3 comments
Open

More discreet "Incompatible browser" message #6284

kontrollanten opened this issue Mar 22, 2024 · 3 comments
Labels
Status: Waiting for answer Waiting issue author answer

Comments

@kontrollanten
Copy link
Contributor

Describe the problem to be solved

A lot of smart TV's has old browsers installed and no easy way to update the browser. Today the "Incompatible browser" message takes a huge amount of area of the site which gives the user the feeling that's something is broken.

image
image

Describe the solution you would like

Even though the browser is old and it's not supported by Peertube it may still be working. Therefore I'd propose to have a clear message that explains that this browser is not supported, but you can continue on your own risk. A simple solution could be the one below, but it could be even more discreet.

image

@Chocobozzz
Copy link
Owner

Do you know what is the JS error that leads to this message?

I think we should hide the angular application in such a scenario because we're not sure how the application will behave.

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Mar 25, 2024
@kontrollanten
Copy link
Contributor Author

Do you know what is the JS error that leads to this message?

No, unfortunately I'm not able to reproduce this.

I think we should hide the angular application in such a scenario because we're not sure how the application will behave.

Is the "Incompatible browser" message only shown when there's actually an error or does it only check the browser version? If it's the latter, isn't it better to just show a clear message that says something like "enter at your own risk" since it may work even though it's unsupported?

@Chocobozzz
Copy link
Owner

Is the "Incompatible browser" message only shown when there's actually an error

Yes it's when there is an error (except to detect internet explorer). You can see the logic here: https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/index.html#L70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for answer Waiting issue author answer
Projects
None yet
Development

No branches or pull requests

2 participants