Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldGuard enable-shop flag doesn't work if WORLDGUARD_INTEGRATION is disabled #520

Open
4 tasks done
Phoenix616 opened this issue Jun 14, 2022 · 0 comments
Open
4 tasks done

Comments

@Phoenix616
Copy link
Member

What is happening?

The enable-shop is registered once WorldGuard is detected no matter if WORLDGUARD_INTEGRATION is enabled or not.

Enabling WORLDGUARD_INTEGRATION forces that shops can only be created in regions though so enabling it might not be what a user intends.

What did you expect to happen?

Either

  • WORLDGUARD_INTEGRATION to toggle the registration of the flag and a separate option to toggle the requirement for a region to exist for a shops being created

or

  • the flag to always work even if the integration is option is disabled and the option working like now

Plugin Version

3.12.1

Plugin Config

Default

Server Version

Doesn't matter

Server Log

doesn't matter >;)

What other plugins are you running?

WorldGuard (any supported version)

Agreements

Additional context

More a note for me/anyone who wants to create a PR/notices this behaviour then anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant