Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the PR magic links strip out all regex comments (?#...) for the "Stack Exchange search in text, in URLs, and in code." #9814

Open
jeffschaller opened this issue Dec 30, 2023 · 2 comments
Open

Have the PR magic links strip out all regex comments (?#...) for the "Stack Exchange search in text, in URLs, and in code." #9814

jeffschaller opened this issue Dec 30, 2023 · 2 comments
Assignees
@jeffschaller
Labels
area: blacklists area: git type: enhancement Improvements which don't reach the level of being new features.

Comments

@jeffschaller
Copy link
Contributor

It would make it quicker / easier to find any on-site hits while looking to approve PR's.

For example, foobarbaz(?#madeup) would result in search links for just foobarbaz.

I believe this needs to happen in gitmanager.py circa line 198 to add some pre- or in-line processing of arg 7.

Looks like something similar was tackled in #2437 with 9a71561 so hopefully similar code could be used here.
@jeffschaller jeffschaller self-assigned this Dec 30, 2023
@makyen
Copy link
Contributor

makyen commented Dec 30, 2023

By "on-site" do you mean "on the global SE Network site" or "on MS"?

@jeffschaller
Copy link
Contributor Author

By "on-site" do you mean "on the global SE Network site" or "on MS"?

The global SE Network site -- the three "text", "URL" and "code" links.

@makyen makyen added area: blacklists area: git type: enhancement Improvements which don't reach the level of being new features. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffschaller jeffschaller

Labels
area: blacklists area: git type: enhancement Improvements which don't reach the level of being new features.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makyen @jeffschaller