Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated MS search lacks body_is_regex=1 #10228

Open
tripleee opened this issue Mar 4, 2024 · 0 comments
Open

Generated MS search lacks body_is_regex=1 #10228

tripleee opened this issue Mar 4, 2024 · 0 comments

Comments

@tripleee
Copy link
Member

tripleee commented Mar 4, 2024

What problem has occurred? What issues has it caused?

When you create a PR from chat, SmokeDetector follows up with search results after a while. However, the generated search fails to specify that the search is for a regular expression. Thus e.g. #10227 has a search which could never work.

(It didn't work anyway for other reasons, but without the "regex" check box, it couldn't have.)

What would you like to happen/not happen?

The generated search should have the regex box ticked. That is,

MS search [here](https://metasmoke.erwaysoftware.com/search?utf8=%E2%9C%93&body=85275+87805%28%3F%23NO+NorAm%29)

should be

MS search [here](https://metasmoke.erwaysoftware.com/search?utf8=%E2%9C%93&body_is_regex=1&body=85275+87805%28%3F%23NO+NorAm%29)
@tripleee tripleee changed the title Generated MS search lacks is_regex=1 Generated MS search lacks body_is_regex=1 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant