Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High outliers for some REST API responses #6691

Open
nflaig opened this issue Apr 19, 2024 · 2 comments
Open

High outliers for some REST API responses #6691

nflaig opened this issue Apr 19, 2024 · 2 comments
Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix scope-performance Performance issue and ideas to improve performance.

Comments

@nflaig
Copy link
Member

nflaig commented Apr 19, 2024

Based on the metrics, it looks like some REST API responses have pretty high outliers while the average responses times are quite low.

Requests pulling data from network

Might be related to the API pulling (or pushing) data from the network

getPeers

(needs more buckets between 100ms-1s)

image

prepareBeaconCommitteeSubnet

(needs more buckets between 100ms-1s)

image

Requests pulling data from state

While other APIs that involve just pulling data from head state don't have this issue

getStateFinalityCheckpoints

image

getStateValidators

(querying for low validator count)

image

@nflaig nflaig added scope-performance Performance issue and ideas to improve performance. meta-investigate Issues found that require further investigation and may not have a specific resolution/fix labels Apr 19, 2024
@g11tech
Copy link
Contributor

g11tech commented Apr 19, 2024

one should measure 95 percentile response, as thats what other seems to be measuring

@nflaig
Copy link
Member Author

nflaig commented Apr 20, 2024

one should measure 95 percentile response, as thats what other seems to be measuring

That's a good idea to have as a panel as avg time might not be a good indicator a lot of the times. Histograms (by bucket) is the best way to detect high outliers though, but the problem is that it does not work well with api responses times as we need to look at the data per api (operationId) so we you would need a panel per api to properly visualize it.

But the fact that there are some getPeers requests that take > 1 second is definitely something we need to investigate.

Looking at the 95th percentile for getPeers it still looks fine, we might need more buckets between 100ms-1s to get better data.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-investigate Issues found that require further investigation and may not have a specific resolution/fix scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

2 participants