Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block signature verification #6613

Open
twoeths opened this issue Mar 29, 2024 · 2 comments
Open

Improve block signature verification #6613

twoeths opened this issue Mar 29, 2024 · 2 comments
Labels
meta-feature-request Issues to track feature requests. prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements. scope-ux Issues for CLI UX or general consumer UX.

Comments

@twoeths
Copy link
Contributor

twoeths commented Mar 29, 2024

Problem description

When we receive an invalid signature block, we log something like:

1431597:Mar-28 17:05:14.470[network]          warn: Error receiving block slot=8735124, peer=16Uiu2HAmQMr7RYZPDb56G7LzuRPMaf7upo2r6keaYDsBQAEqhFA7, code=BLOCK_ERROR_INVALID_SIGNATURE, slot=8735123

while Prysm logs more specific error:

Mar 28 10:05:13 t beacon-chain[1075038]: time="2024-03-28 10:05:13" level=error msg="Could not handle p2p pubsub" error="failed to validate consensus state transition function: could not execute state transition: could not process block: process_sync_aggregate failed: could not verify sync committee signature: invalid sync committee signature" prefix=sync topic="/eth2/6a95a1a9/beacon_block/ssz_snappy

Solution description

we should be able to log which specific signatures of block are invalid. When a gossip block already fails signature verification, we should do a retry to know which signatures are invalid since timing is not important anymore

Additional context

No response

@twoeths twoeths added the meta-feature-request Issues to track feature requests. label Mar 29, 2024
@philknows philknows added scope-logging Issue about logs: hygiene, format issues, improvements. scope-ux Issues for CLI UX or general consumer UX. prio-high Resolve issues as soon as possible. labels Apr 1, 2024
@philknows
Copy link
Member

I would like see if we can prioritize this one only because this concerns an important part of block production. Please discuss if in disagreement. Prioritizing high on this one.

@twoeths
Copy link
Contributor Author

twoeths commented Apr 2, 2024

I'd make this as medium as it's all about logging only, it does not change any functionalities. And we want it for all blocks we receive, not only the block produced by "this node"
but it's really nice to have the expected log in order to ease any investigation when we receive an invalid signature block again

@philknows philknows added prio-medium Resolve this some time soon (tm). and removed prio-high Resolve issues as soon as possible. labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests. prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements. scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Development

No branches or pull requests

2 participants