Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAIP-122: address or account_id? #266

Closed
jdsika opened this issue Feb 27, 2024 · 2 comments · Fixed by #272
Closed

CAIP-122: address or account_id? #266

jdsika opened this issue Feb 27, 2024 · 2 comments · Fixed by #272

Comments

@jdsika
Copy link

jdsika commented Feb 27, 2024

I was wondering why the term "address" is used in the example message structure and the data model even if it clearly states that the chain ID should be used as a prefix. In this case the name should be "account_id" as of CAIP-10?

In addition the place in the example message where it states blockchain should be namespace{account_id} imo?

@jdsika
Copy link
Author

jdsika commented Mar 6, 2024

Another question:
In CAIP-10 you use underscores like "account_id" but in the data model of the CAIP-122 you use dashs like "expiration-time". I think there should be a naming convention that says either or?

@bumblefudge
Copy link
Collaborator

I think CAIP-122 was modeled on EIP-4361, where "address" was used-- it would be more consistent with CAIP-10 (and more chain-agnostic) to call it an account_id tho, since that's what you're authenticating? feel free to open a PR for this.

as for the convention, there isn't one project-wide or org-wide. maybe there should be? if you open a separate PR on https://github.com/ChainAgnostic/CAIPs/blob/main/CONTRIBUTING.md#style-guide I will shop it around to other contributors and if it gets traction I will update all pre-final CAIPs accordingly. I don't know that an org-wide convention for property names/syntaxs makes a lot of sense because many of those have to conform to use-case-specific conventions and user/dev expectations, but definitely the "internal stuff" like how we refer to components of a CAIP scheme definitely would benefit from a convention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants