Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesium-native assertions no longer work with latest NDEBUG changes #1366

Open
csciguy8 opened this issue Feb 27, 2024 · 0 comments
Open

Cesium-native assertions no longer work with latest NDEBUG changes #1366

csciguy8 opened this issue Feb 27, 2024 · 0 comments

Comments

@csciguy8
Copy link
Contributor

csciguy8 commented Feb 27, 2024 •
edited

NDEBUG was defined for debug cesium-native builds as of this PR, #1365

but it seems that asserts are no longer firing.

The intent of the PR was to solve any problems with mismatched headers between the cesium-native and plugin builds... but is it worth this tradeoff?
@csciguy8 csciguy8 changed the title Consider not defining NDEBUG for cesium-native debug builds Cesium-native assertions no longer work with latest NDEBUG changes Feb 27, 2024
@csciguy8 csciguy8 mentioned this issue May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csciguy8