Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user configure whether raster overlay textures are sRGB #1358

Open
kring opened this issue Feb 21, 2024 · 0 comments
Open

Let the user configure whether raster overlay textures are sRGB #1358

kring opened this issue Feb 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kring
Copy link
Member

kring commented Feb 21, 2024

Currently, Cesium for Unreal marks all raster overlay textures as being sRGB. This is a big problem if the pixel values are meant to be some sort of data rather than an sRGB color.

Instead, we should make it a configurable property of the raster overlay. As indicated in this TODO:

auto texture = CesiumTextureUtility::loadTextureAnyThreadPart(
CesiumTextureUtility::GltfImagePtr{&image},
TextureAddress::TA_Clamp,
TextureAddress::TA_Clamp,
pOptions->filter,
pOptions->group,
pOptions->useMipmaps,
true); // TODO: sRGB should probably be configurable on the raster
// overlay

@kring kring added the enhancement New feature or request label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant